FFG Forum Archive

Posted at 2013-12-19 15:15:13+00:00

Hey OggDude -

Please wrap the contents of SetNameTip() (SpecTree.cs, line 362) in a try/catch. I found that on a few of my machines, there was a problem with custom talents, and it was throwing an exception. I decompiled the .exe and fixed the problem by wrapping the code in that method in try/catch, so I would be thrilled to have that fixed in your next release.

Sneaky, sneaky Do you know what the exception was? Also, what version are you using? The line numbers are going to be different on my side since mine has all of my comments and extra line spacings. Just looking at the the method, you could get an exception if the reference to the talent is null. But that can't happen If a bad talent, or missing custom talent, is in a specialization, it'll crash before it even gets there. If you can tell me what the exception is, and if you can send me the actual decompiled line of code it's occurring on, I can see about fixing any issue.

It wasn't my intent to be sneaky I and the group that I run *love* this tool so don't take my poking the wrong way. I should mention that I reflected the code rather than decompiled it. I just happen to do a lot of .NET reflection in my current (lv 3 Support) job, so I decided to take matters into my own hands.

The talent isn't bad or malformed. It's valid XML, and loads correctly when I use my fix.

Repro steps:

1: Use the data editor to create a new custom talent. The created talent just needs a name and a key, no other options necessary.

2: Either customize an existing specialization or create a new one.

3: Open the char generator and load a character with the edited specialization or purchase it with a new or existing character.

4: You should get the exception as it tries to display the talents.

5: If not, create a couple of other new custom talents and put them into the same specialization - it should blow up.

At one point, I was able to successfully create a custom talent, but I was unable to create a second. Playing around in the XML, I copy/pasted the one that worked, changed its key and then tried again, but it still would not work.

I suspected that it was possibly a race condition, or something similar, where the xml wasn't being loaded or parsed fast enough to be displayed - since it's complaining about a null name tip, but the xml is populated and valid. Wrapping that method in try/catch was my attempt to get a better idea of what was going on, but it ended up resolving the issue on my end.

Here's the function with my change. Otherwise, the exception was being thrown on one of the first few lines (I forget which, it's been a week or two since I was playing in the code).

private void SetNameTip(SpecTreeNode node)
{
    try
    {
        node.NameTip.ToolTipTitle = node.refTalent.Name;
        string text = "Activation: " + ((node.refTalent.Activation == "Passive") ? "Passive" : ("Active (" + node.refTalent.Activation + ")")) + "\n";
        text = text + "Ranked: " + (node.refTalent.Ranked ? "Yes" : "No");
        CharTalent charTalent = this.mChar.Specializations.FindByKey(this.CurrentSpec.Key).Talents.Find((CharTalent tt) => tt.Key == node.refTalent.Key);
        if (charTalent.BonusChars.Count > 0)
        {
            object obj = text;
            text = string.Concat(new object[]
            {
                obj,
                "\nAdds +",
                charTalent.BonusChars[0].Bonus,
                " to ",
                this.mData.Characteristics.FindByKey(charTalent.BonusChars[0].CharKey).Name
            });
        }
        node.NameTip.SetToolTip(node.Name, text);
    }
    catch (Exception e)
    {
    }
}

Version info:

Release 1.0.0.12

Full Exception Text (and screenshot ):

See the end of this message for details on invoking

just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************

System.NullReferenceException: Object reference not set to an instance of an object.

at SWCharGen.SpecTree.SetNameTip(SpecTreeNode node)

at SWCharGen.SpecTree.CreateTalentNode(Talent tal, Int32 Row, Int32 Col)

at SWCharGen.SpecTree.GenerateTalentTree(Specialization spec)

at SWCharGen.Form1.cmbSpec_SelectedIndexChanged(Object sender, EventArgs e)

at System.Windows.Forms.ComboBox.OnSelectedIndexChanged(EventArgs e)

at System.Windows.Forms.ComboBox.WmReflectCommand(Message& m)

at System.Windows.Forms.ComboBox.WndProc(Message& m)

at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)

at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)

at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

************** Loaded Assemblies **************

mscorlib

Assembly Version: 4.0.0.0

Win32 Version: 4.0.30319.18052 built by: FX45RTMGDR

CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll

----------------------------------------

SWCharGen

Assembly Version: 1.0.0.12

Win32 Version: 1.0.0.12

CodeBase: file:///C:/Users/[user]/Dropbox/Star%20Wars/EotE%20Char%20Builder/_SWCharGen.exe

----------------------------------------

System.Windows.Forms

Assembly Version: 4.0.0.0

Win32 Version: 4.0.30319.18036 built by: FX45RTMGDR

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

----------------------------------------

System.Drawing

Assembly Version: 4.0.0.0

Win32 Version: 4.0.30319.18021 built by: FX45RTMGDR

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

----------------------------------------

System

Assembly Version: 4.0.0.0

Win32 Version: 4.0.30319.18034 built by: FX45RTMGDR

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

----------------------------------------

SWCharGenLib

Assembly Version: 1.0.0.12

Win32 Version: 1.0.0.12

CodeBase: file:///C:/Users/mattd/Dropbox/Star%20Wars/EotE%20Char%20Builder/SWCharGenLib.DLL

----------------------------------------

System.Core

Assembly Version: 4.0.0.0

Win32 Version: 4.0.30319.17929 built by: FX45RTMREL

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

----------------------------------------

Microsoft.mshtml

Assembly Version: 7.0.3300.0

Win32 Version: 7.0.3300.0

CodeBase: file:///C:/Windows/assembly/GAC/Microsoft.mshtml/7.0.3300.0__b03f5f7f11d50a3a/Microsoft.mshtml.dll

----------------------------------------

System.Xml

Assembly Version: 4.0.0.0