When adding an attachment that adds Pierce, should it be showing up in the normal Qualities section of the weapon?

Second question, would it be an easy addition to tell it to not print Attachment descriptions? When adding attachments, the equipment lines can get a bit fat.

7 minutes ago, FelixTG said:

When adding an attachment that adds Pierce, should it be showing up in the normal Qualities section of the weapon?

Second question, would it be an easy addition to tell it to not print Attachment descriptions? When adding attachments, the equipment lines can get a bit fat.

What weapon are you doing this on? Its working fine for me.

Crafted heavy rifle, just tried on a standard one, works fine on that.

Transferred it to companion, seems like that might be an issue, added a normal one on that, doesn't show pierce, but standard inventory does.

IE Not showing up on companion inventory attachment, does on PC inventory attachment.

5 hours ago, OggDude said:

Just grant the character whatever money is owed him due to his species or whatever. The changes required to do this automatically just wasn't worth the hassle when the alternative solution is so simple

Sure, no problem. Thanks a lot.

3 hours ago, OggDude said:

Try using the "Decreases Total Encumbrance" mod. The difference between this one and the other one is that 1) it's applied to the final total encumbrance, rather than the encumbrance of a particular item, and 2) because of this, it can lower your total encumbrance to 0.

I have been trying using various combinations of decrease encumbrance and decrease total encumbrance to get what I want as an end result, and I'll probably reach a compromise I'm satisfied with soon. I was really just wondering whether the inability to mod a piece of equipment to zero was intended or not, as I would personally prefer to have that instead of changing the character's overall encumbrance or encumbrance threshold. But then again, I'm just here enjoying your hard work for free, so its no big deal.

Thanks

1 minute ago, Alryon said:

I have been trying using various combinations of decrease encumbrance and decrease total encumbrance to get what I want as an end result, and I'll probably reach a compromise I'm satisfied with soon. I was really just wondering whether the inability to mod a piece of equipment to zero was intended or not, as I would personally prefer to have that instead of changing the character's overall encumbrance or encumbrance threshold. But then again, I'm just here enjoying your hard work for free, so its no big deal.

Thanks

The decrease doesn't change the description on the item, just drops your calculated value down by 1 after equipping it. I had been confused on that part as well.

10 minutes ago, FelixTG said:

The decrease doesn't change the description on the item, just drops your calculated value down by 1 after equipping it. I had been confused on that part as well.

Thinking a little more carefully about it, this seems better than what I previously had in mind. I think that is the road I'll go. Cheers everyone.

55 minutes ago, Alryon said:

I have been trying using various combinations of decrease encumbrance and decrease total encumbrance to get what I want as an end result, and I'll probably reach a compromise I'm satisfied with soon. I was really just wondering whether the inability to mod a piece of equipment to zero was intended or not, as I would personally prefer to have that instead of changing the character's overall encumbrance or encumbrance threshold. But then again, I'm just here enjoying your hard work for free, so its no big deal.

Thanks

Pretty much every place I've seen that lowers encumbrance on an item, it always lowers it to a minimum of 1, which is why that particular mod does it that way.

9 hours ago, GM Fred said:

Hello OggDude,

first, I want to give you my thanks for the great work, you are doing for this community.

Now, in the newest version 2.0.1 I encountered the following problems.

I use the German language pack, but now some of the captions on the character sheet are no longer translated although they are correctly translated in the Language pack. E.g. the captions for GENERAL SKILLS CAREER RANK DICE POOL. Most other translations work.

Also, the char gen changed my keyboard-layout to English for Windows (I have a German keyboard, where some keys are different), probably when I checked the Change Keyboard to current Region checkbox when I was checking out the Language pack.

Cheers and keep up the great work

Fred

Update: It's definitely an issue with the 2.0.1 version. I still have the 2.0.0.4 version on my other system and there all captions are translated correctly.

6 hours ago, FelixTG said:

When adding an attachment that adds Pierce, should it be showing up in the normal Qualities section of the weapon?

Second question, would it be an easy addition to tell it to not print Attachment descriptions? When adding attachments, the equipment lines can get a bit fat.

I had something similar to this when modding weapons for adversaries in GM Tools that some of the mod functions like accuracy and pierce did not adjust the main Qualities line. This was on both blaster pistols and rifles (various types).

I have created my own custom specializations from Endgless Vigil along with custom talents for those trees. Does anyone knows what will happen when I update the Char Gen to the version that includes the sourcebook (it is still not there, but for the future).

1 hour ago, Ferretfur said:

I had something similar to this when modding weapons for adversaries in GM Tools that some of the mod functions like accuracy and pierce did not adjust the main Qualities line. This was on both blaster pistols and rifles (various types).

Examples below of where the mods are not changing the base qualities line on weapons for NPC's (nemesis, adversaries, etc).

9 hours ago, FelixTG said:

Crafted heavy rifle, just tried on a standard one, works fine on that.

Transferred it to companion, seems like that might be an issue, added a normal one on that, doesn't show pierce, but standard inventory does.

IE Not showing up on companion inventory attachment, does on PC inventory attachment.

You'll need to tell me exactly how you crafted the item. I crafted one and Pierce is working just fine. I need to replicate the problem in order to fix it

1 hour ago, NicoDavout said:

I have created my own custom specializations from Endgless Vigil along with custom talents for those trees. Does anyone knows what will happen when I update the Char Gen to the version that includes the sourcebook (it is still not there, but for the future).

Unless your entry keys are the same as Ogg's, removing your custom entries will require you to reassociate those specs to any applicable characters using the new spec listing.

3 hours ago, GM Fred said:

Update: It's definitely an issue with the 2.0.1 version. I still have the 2.0.0.4 version on my other system and there all captions are translated correctly.

I had commented out part of the translation code that translated grid headers. I can't remember why off the top of my head Putting it back solved the problem.

2 hours ago, Ferretfur said:

Examples below of where the mods are not changing the base qualities line on weapons for NPC's (nemesis, adversaries, etc).

Another long-time bug that nobody has noticed until now Adversaries were not calculating qualities derived from attachments. I'm assuming that this was the other problem as well. It's been taken care of.

58 minutes ago, Nytwyng said:

Unless your entry keys are the same as Ogg's, removing your custom entries will require you to reassociate those specs to any applicable characters using the new spec listing.

That's why it's generally not worth putting in your own, since I'll eventually get to it. However, if you really want to, I always make a spec's key the uppercase version of its name. Talents, however, I have no standard for

15 minutes ago, OggDude said:

Another long-time bug that nobody has noticed until now Adversaries were not calculating qualities derived from attachments. I'm assuming that this was the other problem as well. It's been taken care of.

I guess we dont often upgrade gear for bad guys until your players get levelled up a lot. Thanks for sorting it and hope my screenshots helped.

31 minutes ago, OggDude said:

That's why it's generally not worth putting in your own, since I'll eventually get to it. However, if you really want to, I always make a spec's key the uppercase version of its name. Talents, however, I have no standard for

Sometimes I've been able to figure out your key naming conventions, other times, not so much. That (and getting official stats for things that I homebrewed or that first appeared as fan stats like the ITT in RPG's Rebels sourcebook) is why I started including an abbreviation for the source at the beginning of my custom keys. Lets me keep the info there without conflicting with your data until I can get everything associated to your data.

(Back around Special Modifications, I "broke" my son's character because our Droid Tech info conflicted due to using the same key. )

So far, the only code change needed for No Disintegrations was to support Iron Body. This is the first talent that modifies critical rating, so I had to add a feature to my TalentItemChange class, then support it where needed. I also made it a list, so a single talent can support multiple item changes based on different skills, etc. Tested it with characters and adversaries, and it works in both places.

Backgrounds, obligations, species, talents, and specializations are done.

1 hour ago, OggDude said:

So far, the only code change needed for No Disintegrations was to support Iron Body. This is the first talent that modifies critical rating, so I had to add a feature to my TalentItemChange class, then support it where needed. I also made it a list, so a single talent can support multiple item changes based on different skills, etc. Tested it with characters and adversaries, and it works in both places.

Backgrounds, obligations, species, talents, and specializations are done.

Just out of curiosity, how are you interpreting Iron Body? By that I mean, to me it seems pretty clear that the intention is to only reduce the crit rating of unarmed attacks. Then the nature of brawl weapons allows you to pick whichever is better. I have seen people argue however that Iron Body reduces Brawl weapons. Which interpretation are you using for the builder? Does the builder already have logic to pick whichever crit value is better?

11 minutes ago, SladeWeston said:

Just out of curiosity, how are you interpreting Iron Body? By that I mean, to me it seems pretty clear that the intention is to only reduce the crit rating of unarmed attacks. Then the nature of brawl weapons allows you to pick whichever is better. I have seen people argue however that Iron Body reduces Brawl weapons. Which interpretation are you using for the builder? Does the builder already have logic to pick whichever crit value is better?

I believe it's been confirmed by devs in other places that any Brawl attack is considered an unarmed attack since any brawling weapon you use just adds to or modifies a basic unarmed attack. So the chargen wil reduce crit on any Brawl attack, no matter if it's using a brawling weapon or not.

12 minutes ago, OggDude said:

I believe it's been confirmed by devs in other places that any Brawl attack is considered an unarmed attack since any brawling weapon you use just adds to or modifies a basic unarmed attack. So the chargen wil reduce crit on any Brawl attack, no matter if it's using a brawling weapon or not.

True, but brawl weapons only augment brawl attacks replacing the players unarmed stats with their own if they are better (see brawl weapon description). That means that Iron Body indeed improves the players base unarmed attack first, then a brawl weapon comes in and overwrites the base stats with its own (when they are better). They may seem subtle, but it's dramatically changes the power level of Iron Body. In one instance, two ranks in Iron Body take Vambracers to Crit 1 and in the other they stay crit 3 for example. I would encourage you to reread the brawl weapon description, as my brawler would love it if I was wrong on this account.

Regardless, I plan on submitting the question on the ND edition of the Order 66 podcast and hope for some clarification.

7 hours ago, OggDude said:

You'll need to tell me exactly how you crafted the item. I crafted one and Pierce is working just fine. I need to replicate the problem in order to fix it

Sorry, I had meant I clicked the template, hit finish, then attached.

Glad the others helped with info.

Some notes on ship XML weapon entries which could be corrected:

note: what follows is my XML of the weapons as referenced from the generator)