It's not too surprising for Space Vampires to live a long **** time, and that's sort of the theme of the Blood Angels, even if they don't actively consume blood to maintain their longev...ah crap.
I like to think that your typical Space Marine can live for half a millennium, give or take. More often, just as long as the Emperor needs them to. I've seen humans in this material who make it to 300 (Honorable Cal), without extensive cybernetics, Halo devices, or what have you, and Space Marines are made from the best of what baseline Humans can be, made better with extra bits, and access to the best technology available. As was said, their maximum life expectancy is also somewhat irrelevant, as there are never enough Astartes to render most of them unnecessary; at times, the Imperium barely has enough GUARDSMEN, and they have much less stringent mandatory qualifications. Most Space Marines can expect to die in battle, and most wouldn't have it any other way; it's who they are.
I can certainly see a logic to the Emperor breeding in some sort of "die off" switch in his super-soldiers; even many of our own real life soldiers find it difficult to reacclimatize to "peaceful" life, and only after a few years of service, in what is comparably humane warzones. Think of the nightmares an Astartes could witness in 300 years of grimdark line-breaking, surprise assaults, and 1000-to-1 faceoffs, and then imagine them trying NOT to be soldiers, later. However, one must then imagine that the Emperor envisioned a time of peace, which would have been folly for Him, and He'd know it. Humans are violent, and look for war, on average, and there are numerous alien menaces to contend with, including infinite Orks, seemingly similar Nids, and numerous other smaller, but no less lethal empires, like Eldar, Necrons, and Tau. If He knew He'd need super-soldiers for any of these, it makes more sense that they are so durable, healable, and long-lived; they'll always have a job. If they have a magic cut-off date, like the rest of us do, it's mostly just that the Emperor, for all His knowledge, had a few issues even He couldn't overcome. He also, initially, couldn't have planned for His own absence, so He would've expected to be present to maintain the integrity of His Astartes, keeping them, and their Primarchs, in line.